Eric Huss

Results 751 comments of Eric Huss

rustup review tracking: * [ ] @rbtcollins * [ ] @hi-rustin

@rfcbot concern rustup-approval

Thanks @rbtcollins for the review! > A nit: On Windows C:\ is not world writable by default. The default permissions are read-only + create folders for users, with only Administrators...

I don't think artifact-dependencies is a complete alternative. As discussed in this RFC text, it is not possible to directly run binaries from artifact-dependencies on the command-line. There are some...

I'm going to propose to postpone this RFC. The Cargo team agrees that this seems like it would be useful and a good idea. However, there are some details to...

I filed an upstream issue at https://github.com/libgit2/libgit2/issues/6588.

Thanks for the PR! I'm a bit confused on the motivation here. How can the colors get out of sync? Each theme defines all the colors for highlighting in one...

The `http2` feature needs to be enabled in Cargo.toml (like `curl = { version = "0.4.44", features = ["http2"] }` and set the version in the code with [`http_version`](https://docs.rs/curl/latest/curl/easy/struct.Easy2.html#method.http_version).

A PR to add a binding for that option would be welcome. I think it would just roughly follow the form of the other options.

Thanks for the report! To support RTL, you need to set the `book.text-direction` option (see [docs](https://rust-lang.github.io/mdBook/format/configuration/general.html?highlight=rtl#supported-configuration-options)). As for search support, that is tracked in #1081.