ehmicky

Results 372 comments of ehmicky

Hi @russelldavis, Thanks for filing this issue. This is a bug in the library that `zip-it-and-ship-it` is using to parse Node.js Function files [`node-precinct`](https://github.com/dependents/node-precinct): I would suggest filing an issue...

> To be clear, declaring the same function twice is not an intentional pattern. But when it happens accidentally, the code still works, and zip-it-and-ship-it shouldn't break working code. (For...

Thanks for investigating this @russelldavis! Would you like to create this issue in `node-precinct` and link it in the current issue?

> Could we read it from the framework's engines.node field, rather than the plugin's? Yes, this makes lots of sense. Please note that I meant the above to be specific...

This is a reasonable approach @erezrokah :+1: One potential gotcha is that some frameworks (like Nuxt) do not have an `engines.node` field. However, that field is best practice and I...

@ascorbic This PR is upgrading ESLint to v8. We also switched from `eslint-plugin-node` (now unmaintained) to its fork `eslint-plugin-n`, which explains why this PR is renaming it. Note: those changes...

Yes! :100: Related: https://github.com/netlify/buildbot/issues/682

From discussing with @fool and @keiko713, we are proposing tweaking the solution above. Instead of always running the default Node.js version, we would instead try to run the same major...

Another option could also be to use the `NVM_NODEJS_ORG_MIRROR` environment variable which allows adding mirrors. This would remove any need to cache the Node.js binaries ourselves, by relying on mirrors...

Note: this problem also happens ~20 times per day due to transient network errors when `nvm` is fetching https://nodejs.org/dist/index.json, which would also be solved by this issue.