ehmicky

Results 372 comments of ehmicky

I did some additional digging. ## Background problem In Node.js, [`source.pipe(dest)`](https://nodejs.org/api/stream.html#readablepipedestination-options) does not do proper error handling. In particular, any `error` in `source` is not propagated on `dest`. So `dest`...

`through2` is using `readable-stream`, which is itself an older version of `node:stream`. For me, `through2` is not working either. My PR on `streamx` was rejected, as apparently the bug (silently...

It seems like the only place retrieving `state.json` is here: https://github.com/netlify/cli/blob/f88b460882a43b63d4997f930722519e9fbdd8bb/src/utils/state-config.js#L17-L25 So, it looks like the situation above would happen for any user who has a `~/.netlify/state.json` file on their...

Yes, I agree. When a user is running a `netlify` CLI command and `cwd` is the home directory, what should happen? The current code is assuming that there is always...

Hi @unlight, Thanks for reporting this. TypeScript ESLint is using a TypeScript parser, which does not recognize modern-errors error classes as inheriting from `Error`. In particular, the following function returns...

Fixed by https://github.com/nodejs/node/pull/57695 which will probably land in `23.12.0`.

It landed in Node.js `24.0.0`. So the wrong behavior is from `23.4.0` to the last version of `23.*.*` (as of now, `23.11.1`).

Underlying Node.js bug still open at: https://github.com/nodejs/node/issues/42923#issuecomment-3448792053

Hi @MaddyGuthridge, Thanks for reporting this. The return value of `.pipe()` is a `Promise` with an additional `.pipe()` method. As opposed to a `Subprocess`, which means it lacks the additional...

I would personally prefer to keep this workaround in this issue only, to encourage myself to fix this. :)