ehmicky
ehmicky
You're right. The solution to this problem should be to combine both: - `utils.cache.list()` should not recurse (`depth: 1`), return both files and directories (`type: 'all'`) and return an array...
The first part has been fixed in #1573. The second (adding `utils.cache.listDeep()`) requires dropping support for Node `
Thanks a lot for this information, this is very helpful! :heart:
Thanks for reporting this @mheffner. This turned out to be a problem more subtle than it seemed, sorry for the long response! ## Same header, same case ### TOML Per...
It does seem like both solutions would be breaking changes and require some initial warnings and metrics, as you mentioned. I agree that both solutions are quite imperfect (including what...
This sounds like a good first step! :+1:
PR to add the warning message: https://github.com/netlify/build/pull/3590
[Humio query](https://cloud.us.humio.com/netlify-us-production/search?query=%22the%20same%20header%20is%20set%20twice%20with%20different%20cases%22%20%7C%20not%20%22ehmicky%22&live=false&start=7d&fullscreen=false) for the warning message. [Example of a site](https://github.com/GoodDollar/GoodDAPP/blob/master/netlify.toml) which does intend to override (current behavior), not concatenate headers of the same name (but different cases), between different paths....
PR to improve the warning message based on my comment above: https://github.com/netlify/build/pull/3594 New Humio queries: - [Query](https://cloud.us.humio.com/netlify-us-production/search?query=%22the%20same%20header%20is%20set%20twice%20with%20different%20cases%20for%22%20%7C%20not%20%22ehmicky%22&live=false&start=7d&fullscreen=false) for headers with same name, different cases and same `for` path - [Query](https://cloud.us.humio.com/netlify-us-production/search?query=%22the%20same%20header%20is%20set%20twice%20with%20different%20cases%3A%22%20%7C%20not%20%22ehmicky%22&live=false&start=7d&fullscreen=false)...
## Findings Findings from production monitoring: - Only [a small handful of sites](https://cloud.us.humio.com/netlify-us-production/search?query=%22the%20same%20header%20is%20set%20twice%20with%20different%20cases%20for%22%20%7C%20not%20%22ehmicky%22%20%7C%20groupBy%28repo_url%29&live=true&start=7d&fullscreen=false) are using headers with the same name, different cases and the same `for` path. It appears that...