Eric Han
Eric Han
Hmm, I'm still unable to build iOS App after rebasing on the main branch. I got following error when run `pod install` ```txt [!] The following Swift pods cannot yet...
> The local preview do not match the one returned by the server Oh yes, I also noticed this but it seems hard to implement the same with what backend...
> @eh2077 Please check [#35255 (comment)](https://github.com/Expensify/App/pull/35255#discussion_r1471656045) > > For the password bug, I think we should show an error if the user is uploading a password protected file since the...
@s77rt My updates are as follows For the password protected issue, I tried to find a method from `react-pdf` lib to check if it's protected by checking the local file...
@s77rt Sorry for the delay. I'm working on fixing the endless prompt. I'll push an update early tmr.
@s77rt I did a forced push in this PR to solve conflicts and avoid missing changes from main branch. I fixed the endless password prompt issue of web platform (native...
> @eh2077 Please do not force push. This messes up the review process. Can you try undo that force push? Ah, sorry but it can't be restored. Don't worry I...
> > If the pdf uploaded is protected, it shows the FullScreenLoadingIndicator > > That may confuse the user, can we show instead the generic pdf thumbnail? Yes, indeed it's...
> On the error handling why are we navigating to the confirmation page? @trjExpensify Good question! Hmm the tricky part here is that we need to load PDF to know...
> Should we stop that background spinner and use the "empty state" thumbnail default once we've read it? That's what makes the background look a little janky because it's continuing...