Eric Han
Eric Han
> Should we stop that background spinner and use the "empty state" thumbnail default once we've read it? That's what makes the background look a little janky because it's continuing...
@s77rt PR is updated and this time I managed to solve conflicts without force push. I found that I really like rebasing-and-force-pushing a PR. I think it has benefits to...
@FitseTLT Yeah, sure! We can hold this PR a bit as we're waiting for the translation.
reviewing proposals
@dragnoir 's [proposal](https://github.com/Expensify/App/issues/40686#issuecomment-2069524832) looks good to me. I agreed with their RCA and the solution. Implementation details can be discussed in PR. 🎀👀🎀 C+ reviewed
I found that `policyDraft` also has `employeeList` https://github.com/Expensify/App/blob/0c2d5130727105535ee16ec0b5e932456ce3fea5/src/libs/actions/Policy.ts#L2086-L2112 > Should we always look at the policy employee list for `isAdmin`? So, I think it'll be neat to only check `employeeList`....
> If we use `employeeList` from Policy, the value will be available from all devices. @dragnoir This is exactly what I mean given they're coalesced here https://github.com/Expensify/App/blob/98d85e0863fe62292a7a086f6cf4bfb4c5b59fdc/src/pages/workspace/WorkspaceInitialPage.tsx#L81
Not overdue, waiting for @stitesExpensify to check if it's good to assign or not
Sure 🎀👀🎀 C+ reviewed