Enrico Guiraud comments

Results 153 comments of


                                            Enrico Guiraud

[Tree] Bogus data silently read when trying to access an indexed friend TTree with an invalid index

This definitely exists since the beginning of time, and I completely understand the situation with the release. In fact, the same thing happened with 6.26 and then 6.28. Just allow...

ROOT does not compile with link-time optimizations (LTO) enabled

Note that there is also a problem with LLVM and LTO: https://github.com/root-project/root/issues/11135

TChain:: add AddFilelist (AddFile loop over a filelist)

@phsft-bot build

TChain:: add AddFilelist (AddFile loop over a filelist)

I leave it to the I/O experts to review the PR -- we are missing a test for the new feature though

[ntuple, tidy] First attempt at a default set of checks and some fixes

Hi Jakob, I don't know much about clang-tidy, why this specific set of checks?

[ntuple, tidy] First attempt at a default set of checks and some fixes

I tried this clang-tidy configuration on the RDF code. Compared to the default configuration, which gives me almost zero errors, this conf produces 21k lines of errors. There are a...

[ntuple, tidy] First attempt at a default set of checks and some fixes

Alright! One other noisy check is the one for magic numbers: it complains about data member initialization such as `fNBins = 64`, which would not really be improved by a...

[ntuple, tidy] First attempt at a default set of checks and some fixes

About > it would be nice to exclude the Google stuff from clang-tidy but keep our code under scrutiny. Not sure if this can be done though. I think at...

[ntuple, tidy] First attempt at a default set of checks and some fixes

Another one that we can't have ROOT-wide is `modernize-concat-nested-namespaces`

[ntuple, tidy] First attempt at a default set of checks and some fixes

This one instead I guess is arguable, I don't mind fixing the (many) occurrences in `tree/dataframe` but I'd say it only makes sense if we make it part of ROOT...