TChain:: add AddFilelist (AddFile loop over a filelist)

Open adriansev opened this issue 3 years ago • 10 comments

This Pull request:

Changes or fixes:

Add TChain::AddFilelist which will call AddFile for each member in filelist It hase the same signature of AddFile and will return the sum of each AddFile operation.

Checklist:

[x] tested changes locally
[ ] updated the docs (if necessary)

Jan 25 '22 16:01 adriansev

Can one of the admins verify this patch?

Jan 25 '22 16:01 phsft-bot

@phsft-bot build

Jan 26 '22 10:01 eguiraud

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, ROOT-ubuntu2004/soversion, mac1015/python3, mac11/cxx17, windows10/cxx14 How to customize builds

Jan 26 '22 10:01 phsft-bot

I leave it to the I/O experts to review the PR -- we are missing a test for the new feature though

Jan 26 '22 10:01 eguiraud

Build failed on ROOT-ubuntu16/nortcxxmod. Running on sft-ubuntu-1604-4.cern.ch:/build/workspace/root-pullrequests-build See console output.

Failing tests:

Jan 26 '22 10:01 phsft-bot

Build failed on ROOT-performance-centos8-multicore/default. Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build See console output.

Failing tests:

Jan 26 '22 11:01 phsft-bot

Build failed on ROOT-debian10-i386/cxx14. Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build See console output.

Failing tests:

Jan 26 '22 12:01 phsft-bot

i suspect and hope that my PR have nothing to do with roottest_cling_exception_nullderef tests .. is it correct?

Jan 29 '22 10:01 adriansev

Thanks for your contribution, @adriansev !

Jan 31 '22 12:01 Axel-Naumann

Thanks! I seen the comments and i will address them point by point. Many thanks!

Jan 31 '22 21:01 adriansev