Enrico Guiraud comments

Results 153 comments of


                                            Enrico Guiraud

Improve RArrowDS and introduce RCombinedDS

Hi, I'm picking this up (thanks @linev for assigning me). #3433 should be merged first. It just requires rebasing and fixing a trivial conflict. For this PR: I will review...

Improve RArrowDS and introduce RCombinedDS

Discussing with @ktf, we decided to add `RCombinedDS` as a friend of `RDataSource` to avoid the `#define protected public` that is now required to call `GetColumnReadersImpl` from `RCombinedDS`. I will...

Improve RArrowDS and introduce RCombinedDS

...thank you @phsft-bot

Improve RArrowDS and introduce RCombinedDS

@pcanal also needs a couple more things, see my last comment. It's on my to do list.

[IO] `TCling::GenerateDictionary` is broken for `RVec<CustomType>`

A more minimal reproducer that catches at least some of the problems: ```cpp // LinkDef.h #include #include "TwoInts.h" #ifdef __CLING__ #pragma link C++ class ROOT::VecOps::RVec+; #pragma link C++ class ROOT::VecOps::RVec::*+;...

[IO] `TCling::GenerateDictionary` is broken for `RVec<CustomType>`

This is still a problem in v6.26.

[IO] `TCling::GenerateDictionary` is broken for `RVec<CustomType>`

I was just hit by this again after forgetting about it again :smile: ping @pcanal @Axel-Naumann :grimacing:

Reserve "build" directory name in ROOT sources for build files

Hi, little ping on this, it would be a big quality of life improvement for me :)

[Tree] Bogus data silently read when trying to access an indexed friend TTree with an invalid index

Adding the 6.26 milestone after discussion with Axel

[Tree] Bogus data silently read when trying to access an indexed friend TTree with an invalid index

Hi, this is still an issue. TChain and TTree silently return the last valid value for an indexed friend tree if the main one asks for a non-existing index. #12260...