Egon Willighagen

Results 303 comments of Egon Willighagen

On Mon, Nov 11, 2013 at 5:34 PM, Andrea Di Menna [email protected] wrote: > 1) is very easy to implement but could potentially break something (not 100% sure) > 2-3)...

In case of chemical, templates are used to annotate properties of the central class... E.g. for Azulene for CAS/KEGG/ChemSpider/PubChem identifiers do not define subclasses, but are "properties" of azulene itself.

@fnielsen, @Daniel-Mietchen, please let me know what you think a patch to do this should take into account.

> Yes. Long time ago we an issue or PR. @fnielsen, can you help me out? I can find the following related queries, but none capture this issue (fully): *...

Testing is easier now, and we should be able to just change this line to test with Qlever: https://github.com/egonw/scholia/blob/8ff64dee13940ad28fd5d7dd97ad4bdc2d2628b4/scholia/query.py#L64

> Also awaits the creation of https://www.wikidata.org/wiki/Wikidata:Property_proposal/Creative_work#is_retracted_by We have that property now and this should be added. I was just about to file a feature request when I found this...

Neither. I see this also still needs updating to the new model. I'll do it today.

> The indentation can be removed but I would merge it. @egonw I rebased the patch and removed the indentation: https://github.com/WDscholia/scholia/pull/2452

See also https://phabricator.wikimedia.org/T349911