Chris Markiewicz
Chris Markiewicz
Seems reasonable to me. If there's consensus here, it would be ideal to raise a validator warning and to provide a tool to remove overrides from datasets automatically, with validation...
Tagging as needs implementation. Recommendations without validator warnings will have essentially no impact.
I created https://github.com/bids-standard/bids-validator/issues/117 to track implementation. I think this would be a good first issue for a new contributor to the validator.
xref https://github.com/bids-standard/bids-2-devel/issues/65
Implementation: https://github.com/bids-standard/bids-validator/pull/214
Cc @ericearl
Thanks for this! Would it be possible to get a test that clearly demonstrates the error before and is fixed after?
Hi @gjpcbecq! I'm going to try to turn your MRE into a test. Apologies for taking so long to get back to this. I'm commenting here to try to pressure...
Okay, so I've had a go at reproducing this, and your fix resolves the initial placement at the origin, but if you attempt to click around to other locations with...
Looks like this is showing up in our CI (`dev` run: https://github.com/nipy/nibabel/actions/runs/8776832524/job/24080913543): ``` nibabel/tests/test_arrayproxy.py::test_get_obj_dtype /home/runner/work/nibabel/nibabel/nibabel/tests/test_arrayproxy.py:306: DeprecationWarning: __array__ implementation doesn't accept a copy keyword, so passing copy=False failed. __array__ must implement...