Edward Murphy

Results 24 comments of Edward Murphy

I implemented it in bash here: https://github.com/creationix/nvm/pull/1535

"overwriting shell builtins is a huge no" I completely agree however I think there are other ways nvm could leverage the ability to dynamically interpret semver expressions. For instance what...

That sounds great! There's still a little work left to do but I don't see why we couldn't get this ready to ship. Most of the remaining work is just...

Good points I agree with all three of your responses thanks. Also, could you clarify your concern about this logic being too large to be included? Are you saying you...

Ok that makes sense. I have some ideas I'd like to explore around how to simplify the semver parser logic so I'm going to pursue this a little further. My...

In order to setup a dev environment, I'm assuming I need to run the makefile but I can't get it to complete because 3 tests are locally failing out of...

Oh perfect thanks for pointing that out. I'm guessing my questions will be answered in that thread but I'll message you in there if I'm still stuck.

@ljharb Is the continuous-integration check flaky by any chance? I'm specifically asking about my previous two commits. Are the errors reported in the failed build accurate? My last commit only...

@ljharb Is there a way I can manually trigger a rebuild? Also What do you think about the PR in it's current state? It basically extends the same functionality of...

@ljharb thanks for the review. > parsing the semver range (there's an entire node lib, semver, to handle this - replicating all of the relevant logic in posix is not...