Edwin Cheng

Results 46 comments of Edwin Cheng

I am trying to understand this bug (and hopefully fix it), and would you mind to explain where the "_PreviewTexture" is used in current code ? I cannot find any...

Thanks for the details reply. And i was getting the same conclusion as the main issue are coming from the `GetVariableNameForSlot `. On the other hand, here is my hacky...

The problem of my fix is I don't know there is no good way to pass the RenderTexture from ``RenderWithMaterialRenderer` to the `BaseUnityTextureNode` (I use global static variable right now,...

> I'm currently working on a fix related to the aspect ratio of the preview (which should be aligned the game view), is it ok if I include your fix...

Hi, Thanks for your detail reply. All your points are valid and i agreed that it is kind of waste of time at this moment. Do you recommend any installation...

I finally manage to convert it to using UPM : https://github.com/edwin0cheng/ImageEffectGraph/tree/support_upm Which solve parts of your concerns: 1. Right now only ShaderGraph and PostProcessing are required packages. We seem to...

I totally understand how painful without proc-macro after reading current `js!` Implementation. 😂 But how about the export functions parts? Even with proc-macro, it seem to not helping a lot...

> for the lexer to know the preceding token We do not need to know a whole token, we only need to know prev char is a "DOT", such that...

Goto definition do not work in `include!` macro yet. Do completion show them correctly ?

@cynecx This is the first issue for that :)