Edward Silverton

Results 185 comments of Edward Silverton

I've created this: https://github.com/IIIF-Commons/vocabulary We could publish this under the @iiif npm namespace. I think we could get the initial enums in there then talk to the software devs community...

Interesting... would it be possible to add your manifest as a test fixture with accompanying test? https://github.com/viewdir/manifesto/tree/master/test/fixtures Maybe just testing that it loads correctly. This would also ensure it doesn't...

I think the ideal thing could be to have an actual nodejs implementation of an auth server, and to make requests against that locally when running the test suite to...

Hmm, `internal.ts` was necessary to _avoid_ circular imports though: https://medium.com/visual-development/how-to-fix-nasty-circular-dependency-issues-once-and-for-all-in-javascript-typescript-a04c987cf0de

Yeah I was thinking to maybe only limit it to the affected files. It's the top four here: https://github.com/IIIF-Commons/manifesto/blob/master/src/internal.ts I'm traveling today, so if you wanted to do a PR...

i.e leave the top four in internal, and remove the rest. The TS compiler will catch the import errors so it should just be a case of adding those back...

I've made a test app: https://github.com/edsilv/exjs-test Test.ts works fine as it's just using your example. However, I'm stuck as to how I should approach Test2.ts. https://github.com/edsilv/exjs-test/blob/master/test/Test2.ts I need to be...

Cool, this works: https://github.com/edsilv/exjs-test/blob/master/test/Test2.ts#L25 for the root-most id. What's the correct method to traverse the child nodes?

This works: `var result = [json2].en().traverseUnique(x => x.service).first(r => r['@id'] === id);` but it needs to be generic as the child arrays could be named anything.