manifesto icon indicating copy to clipboard operation
manifesto copied to clipboard

check for @graph keyword in manifest

Open christopher-johnson opened this issue 8 years ago • 2 comments

See https://github.com/UniversalViewer/universalviewer/issues/385

christopher-johnson avatar Sep 26 '16 08:09 christopher-johnson

Interesting... would it be possible to add your manifest as a test fixture with accompanying test?

https://github.com/viewdir/manifesto/tree/master/test/fixtures

Maybe just testing that it loads correctly. This would also ensure it doesn't break any other tests.

edsilv avatar Sep 26 '16 14:09 edsilv

@edsilv thank you for the reply. I added a test that checks if it loads correctly, and that resources can be read (I reused getManifestType() and getSequenceByIndex(0) ). See lines 117-124 in this file. @graph_test.txt

All other tests still pass with the change.

christopher-johnson avatar Sep 27 '16 16:09 christopher-johnson