manifesto icon indicating copy to clipboard operation
manifesto copied to clipboard

Add tests around Manifesto's auth logic

Open mejackreed opened this issue 6 years ago • 4 comments

mejackreed avatar Nov 04 '19 19:11 mejackreed

@edsilv are there some specific targeted pieces that you think should be tested?

mejackreed avatar Nov 05 '19 16:11 mejackreed

I think the ideal thing could be to have an actual nodejs implementation of an auth server, and to make requests against that locally when running the test suite to test the auth utils.

We could potentially use something like passport.js to create access tokens and simulate a successful user interaction login via twitter/whatever?

edsilv avatar Nov 06 '19 15:11 edsilv

It sounds great to have that entire functionality tested. Would it be ok to start from a simpler place though for the manifesto test suite that gets us closer to a release?

https://github.com/IIIF-Commons/manifesto/pull/58 Just adds some basic tests around Utils. I look at a more comprehensive approach also.

mejackreed avatar Nov 06 '19 15:11 mejackreed

Sure, sounds good.

edsilv avatar Nov 07 '19 08:11 edsilv