Eduard Kerkhoven

Results 185 comments of Eduard Kerkhoven

It touches on this issue, but what you're raising here is really the core of what is proposed in the opening post. Your `getComplexData` function sounds exactly what is required,...

UniProt has indeed changed their API, @johan-gson solved this in #180, has not been reviewed yet.

Selecting maximum kcat from multiple EC models is possible, as the `kcatList` that is used by [`selectKcatValue`](https://github.com/SysBioChalmers/GECKO/blob/f987feded59c51c99e2d0064d068a2a8dfdfeed6/geckomat/gather_kcats/selectKcatValue.m) can contain kcat values from multiple ec-codes (at the moment it does not...

This is only required for the GECKO1&2 legacy fuzzy kcat matching. We'll just continue using this approach, refactored for the GECKO3 model format, as implemented in #188.

This is now generated by [`makeEcModel`](https://github.com/SysBioChalmers/GECKO/blob/feat/makeEcModel/geckomat/change_model/makeEcModel.m) in branch [feat/makeEcModel](https://github.com/SysBioChalmers/GECKO/tree/feat/makeEcModel) (feedback on that function itself are welcome here: #161). The structure changed a bit to what was proposed above. It is...

This is now implemented with #166, but of course the scheme might be modified a bit during the ongoing refactoring.

FYI, after our discussion, this scheme will be modified, to end up with one `model.ec.kcat` entry for each complex (which can have multiple subunits associated).

Simplified scheme introduced with #167 - One entry per reaction - Each entry contains 1 kcat value that is integrated in the model (when `applyKcatConstraints` is run) - No duplicate...

> Ok, seems I lost write access to the repo, I sent a message to Ivan, but any changes may be delayed a bit. Should be fixed now.