Eduardo Gurgel comments

Results 186 comments of


                                            Eduardo Gurgel

Fix formatting in README

Already tried, dude: https://github.com/binarylogic/settingslogic/pull/55

Refuse to encode/decode functions

Thanks for the PR! I will release a new version soon with this security fix!

Feature: Partial request body & Error when limit exceeded

I will play with this PR later this week. Thanks once again for the contribution!

Feature: Partial request body & Error when limit exceeded

@pedep okay! Thank you for pushing this forward to hackney as it seems a more natural place for the feature. Let's see how it goes 👍

Allow to pass encoded params.

I'm not sure if this change is desirable. If you already encoded the query params why would you pass it to the `params` option? The only real "benefit" is that...

refine overridable functions when using module Base.

I think this is an actual bug and it should not be order dependent. Do you mind reopening the PR (if still available)?

Add the location to all responses returned

Thanks for the PR! I will check soon! :+1:

Add the location to all responses returned

If we merge this we will include location to the struct and it will be harder to remove as we would need to deprecate etc etc. I'm not sure if...

Add the location to all responses returned

I think that having the client will be really useful to give proper tools for request and response streaming (https://github.com/edgurgel/httpoison/issues/97)

Add the location to all responses returned

What if we expose `HTTPoison.Response.location/1`? Now it would simply return `location` from the struct but we advise to use the function instead of direct access? Then with next hackney we...