Eduardo Gurgel comments

Results 186 comments of


                                            Eduardo Gurgel

checkout_timeout

Thanks, @pedep !

When following redirects, I'd like to be able to access the final location

That's a great addition to the library. I think we got 2 options: - Add another key to the struct (`location` probably) and populate it if the client has a...

When following redirects, I'd like to be able to access the final location

Yeah the former option seems good short-term but the latter seems better long-term as we won't stop people from using other hackney features. I would be happy to accept a...

When following redirects, I'd like to be able to access the final location

Can you check the headers and see if there's a "location" to follow? I think there's still another redirect to follow as you got a 302 even after 5 redirects....

un-gzip based on content-encoding

This will be done upstream by hackney: https://github.com/benoitc/hackney/issues/155 We can keep this issue open until it's available.

Optionally avoid url encoding params

@axelson have you tried doing this approach you mentioned? Cause I'm worried that hackney will also try to url encode :/

Issue with dialyzer attributes in copied modules.

Hey! 🤔 Interesting! That's definitely a first! Will check it out soon! Hope you are well, too! 👋

Provide a way to raise an error when calling a copied function

One way to achieve this today is creating a common test case using [ExUnit.CaseTemplate](https://hexdocs.pm/ex_unit/ExUnit.CaseTemplate.html) and calling `stub(TheModule)`. Then you just have to ensure that your tests are using this test...

Mimic can't see a function when it's called internally without the module name.

Thanks, @jimsynz . As @jimsynz said there's not much we can do about that. The code must call the fully qualified name `Transactions.delete_something` or it won't be possible to be...

simple api for verifying reject before another expect/stub

I would need to test it myself but I think the issue here is that the call to divide is local so you would need to change the calculate code...