Eric Daniels

Results 68 comments of Eric Daniels

Any word on this @codyoss? We've worked around it with some special casing in our codebase but it'd be nice to remove. Thank you!

> I do not have a timeline, but we do intend to do something about this issue in the future. Perfect. Thanks Cody

@sukunrt nice! As you get ready to put this up for review, could you share some performance testing you do/did with this?

It looks like sync.WaitGroup is in use in transport for connWG and there's no current issues around it being used, so I'll close this issue for now.

@Sean-Der it seems likely users would be relying on Codec and PayloadType being accessible when OnTrack is called. With this change, you'd need to read first before calling those. I...

So if we make it blocking in v3 until the first packet on those two methods, I don't think it's breaking so long as we handle the other cases where...

Yep that's fair. I'm looking at something else I've written for a client as well and it's too subtle to not cause problems. Let's just do this for v4

@cnderrauber tagged you for review for v4 inclusion only

> Looks good for normal track. Another case is the simulcast track still relies on rtp packet to fire the event, we need consistent behavior for all tracks to avoid...

Oh, I see. You're saying it should also fire off the track as well. Let me take a look.