transport icon indicating copy to clipboard operation
transport copied to clipboard

Fix data race on listener.connWG

Open stv0g opened this issue 2 years ago • 1 comments

Fixes #259

stv0g avatar Aug 27 '23 13:08 stv0g

Codecov Report

Patch coverage: 85.18% and project coverage change: -0.11% :warning:

Comparison is base (6890c79) 82.21% compared to head (e209826) 82.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #260      +/-   ##
==========================================
- Coverage   82.21%   82.11%   -0.11%     
==========================================
  Files          37       38       +1     
  Lines        3217     3243      +26     
==========================================
+ Hits         2645     2663      +18     
- Misses        456      461       +5     
- Partials      116      119       +3     
Flag Coverage Δ
go 81.86% <85.18%> (-0.20%) :arrow_down:
wasm 74.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/sync/waitgroup.go 84.61% <84.61%> (ø)
udp/conn.go 83.03% <100.00%> (ø)

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '23 13:08 codecov[bot]

It looks like sync.WaitGroup is in use in transport for connWG and there's no current issues around it being used, so I'll close this issue for now.

edaniels avatar Jul 22 '24 14:07 edaniels