Eric Daniels
Eric Daniels
@jhump I just hit this issue. Should we have this not silently fail? I was getting partial files with this.
> > @craymond12 we can run the tests here! If you open the PR again I can run the tests and if they pass we can merge things. > >...
Also, for what it's worth, I don't think we're in any rush here, so no pressure to respond ASAP to this.
That's fine with me. Do you have any vision for what you'd re-architect to achieve blocking writes? I could "just" go down a proof of concept route to achieve and...
I'll give it a go once some of my paid work lets up :D
hey @yann-y just a heads up we are working on a v2 now that may obviate this issue, but wanted to keep you posted either way
@abhinav bump!
I took a look at this as well in https://github.com/edaniels/grpclib/commit/c38df6ca65f3205e2d94b2b42859fa7ccbeb199d and added a graceful option to `close` and `wait_closed`. It seems to work well