Henrik Andersson

Results 77 comments of Henrik Andersson

Let's add the bathymetry as an optional attribute to the Grid2D data structure.

An alternative worth considering is to add support for [Xugrid](https://deltares.github.io/xugrid/) supporting the [UGRID conventions](https://ugrid-conventions.github.io/ugrid-conventions/) (or the alternative [UXarray](https://uxarray.readthedocs.io/en/latest/) 🤔)

Hi @chrisawhitwell, would you like to submit a PR with your suggestion? The place to start tweaking is https://github.com/DHI/mikeio/blob/d9055794f5f416750b7929e7d1e3cac56a6d5ec2/mikeio/spatial/_FM_geometry.py#L126 Please also add a test that showcases the functionality.

2. No, and I'm not sure it is a good idea to create such a geometry, since the existing geometries [Grid1D](https://dhi.github.io/mikeio/dfs1.html#mikeio.Grid1D), [Grid2D](https://dhi.github.io/mikeio/dfs2.html#mikeio.Grid2D), [Grid3D](https://dhi.github.io/mikeio/dfs3.html#mikeio.Grid3D), [GeometryFM](https://dhi.github.io/mikeio/mesh.html#mikeio.spatial.FM_geometry.GeometryFM), [GeometryFM3D](https://dhi.github.io/mikeio/dfsu-3d.html#mikeio.spatial.FM_geometry.GeometryFM3D), corresponds to different types of...

3, See PR #483 should take you one step closer to being able to concatenate data

After, consistency between values and coordinates. ![image](https://github.com/DHI/mikeio/assets/614215/5b3114fc-cf0a-4f32-80d8-c1943dbae2bb)

#632 is related closely to this PR

@jsmariegaard Merging this PR broke some tests in `modelskill` related to skill 😐 ``` FAILED tests/test_config.py::test_comparison_from_yml - assert 0.2330094096313094 == 0.2331039 ± 2.3e-07 FAILED tests/test_multivariable_compare.py::test_mv_skill - assert 0.2249234222997736 ± 2.2e-07...

I'm trying to understand the parameters of the `peak_ratio` by this Streamlit app I think the `inter_event_level` could be explained in some, perhaps in a Notes section. It is also...

Too bad, so how about copying the most relevant examples to the docs and keeping the notebooks folder as a repository of less polished examples?