New Peak Ratio

[daniel-caichac-DHI]

Hi.

After a long discussion we decided to update the peak selection in the Peak Ratio.

• Before this PullRequest the individual N-largests peaks between model and measurements were selected and then intersected (ie, finding the joint-events only), and the remaining joint-peaks were used in the calculation.
• With this PullRequest , all individual peaks are selected independently (from measurements and model), intersected (finding the joint-events), and then the N-largest peaks are used for the calculation.

Small change but has some implications in the results. Also the number of times the user gets a NaN (no joint events) is much lower now (still can happen with very short time series with no evident peaks). I had to obviously update the tests results of PR as the expected values now change.

Aligns with what was done here: https://github.com/DHI/potpy/pull/39

[ecomodeller]

I'm trying to understand the parameters of the peak_ratio by this Streamlit app

I think the inter_event_level could be explained in some, perhaps in a Notes section.

It is also interesting to understand how the default values for these parameters were chosen.

[daniel-caichac-DHI]

What a pro. I'm amazed.

As for the parameters, I guess we can just reference MIke EVA manual

https://manuals.mikepoweredbydhi.help//2024/General/EVA_UserGuide.pdf

[daniel-caichac-DHI]

@ecomodeller don't forget about the peasants

[daniel-caichac-DHI]

all comments addressed