Eric Charles

Results 535 comments of Eric Charles

> the application that consumes @jupyterlab/shared-models doesn't ship all of @jupyterlab/notebook with it The build process will pull a lot of transitive deps, which is a minor issue. > Why...

@dmonad Error building your latest commits, which makes me think, "Yes, this PR really removes model-db :)". Thx for working on this! ``` ../notebook/src/model.ts:200:10 - error TS2339: Property 'modelDB' does...

Just pulled your latest commit @dmonad and RTC functionality works find on my env. In the meantime, the changes for codemirror6 have been merged, giving conflicts to resolve. Looks like...

@dmonad just tried locally. The RTC functionality does not work (well at some point it synced a cell with a lot of latency). The cursor are not shown and I...

I have relaunched the js-services test and it is now green. I was on a wrong env. Started again from source with tag `v4.0.0a26` with valid RTC. Same env, with...

Just tried again. The RTC changes are not shown in the second browser. The second browser hangs when running cell. When I stop the server, it exits with `RuntimeError: Cannot...

> I also had a weird behavior when trying RTC with this branch. It might also be caused by the switch to CodeMirror 6. That is very much possible. This...

I have tried on my local env and the cells run fine, but the RTC feature is not shown (the text does not sync, the shared cursor is not shown)....

> Should this approach be generalized to all outputs (not only widgets), and become the https://github.com/jupyter-server/jupyter_server/pull/891#issuecomment-1167099693? I don't fully yet get sense on that "new trust mecanism" looking at this...

If it can help to find cause..., changing the tab when the shortcut does not work anymore makes it work again.