Eric Charles

Results 535 comments of Eric Charles

> With the reproduce example above, I am able to fix it by changing the prefered_dir setting to os.getcwd().lstrip('/') @andrewfulton9 Where have you changed that (had a look in jupyterlab,...

Very interesting issue. A few random thoughts: - As @SolarisYan describes it well, I see the jupyterlab client initiating new sessions (new session_id) with my local server. I can understand...

> It definitely cannot ever be the front-end's responsibility to implement anything security related, so 1. is really the only option. +1

While this works fine when the user clicks on the menu to show the configurator page (http://localhost:8888/tree?#nbextensions_configurator), it does not solve the issue when the user directly types in his...

@juhasch Have you bandwidth to review and help with this? Anyone else interested to have a look? Thx!

I am adding @damianavila as potential reviewer of this PR (just seeing Damian is part of this `jupyter-contrib` github organisation). Happy to answer any question on these changes which are...

Thx @damianavila for the comment. @juhasch Do you have any question on this change. It is working fine on my env for notebook 6.4.x, 6.5.x and nbclassic.

@bnavigator nblcassic>=0.4 is a replacement to notebook-6.x, so both should not be installed at the same time. Do you have cases where you need both? We were planning to fail...

> You may have planned that, but the reality is different: This was an idea to clarify things and any feedback can change that. > Despite your PR having a...