Eric Charles

Results 535 comments of Eric Charles

OK I see now, 3 of the 4 entrypoints collide. Thx for raising that. If a user installs notebook-6.5, the nbclassic dependency will be first installed, then the notebook 6.5...

For the jupyterlab case, this may be more tricky as it may depend on notebook and nbclassic. Should we revisit the jupyterlab dependency constraints?

> Be aware that this is not a discussion about your future plans but about an existing problem of released packages. notebook 6.5 is beta pre-release to gather this kind...

> but you are making life for distro packagers unnecessary hard. Really sorry about that. An really appreciated the time and feedback here. > If you already require nbclassic in...

> It is already a problem with notebook 6.4 You mean in the jupyterlab scenario? @jtpio @fcollonval Would it make sense to pin nbclassic

> Isn't that already what was implemented in https://github.com/jupyterlab/jupyterlab/pull/12767? The title is confusing and should be changed. What has finally been merged is https://github.com/jupyterlab/jupyterlab/pull/12767/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R40-R41

> In any scenario where nbclassic and notebook is installed A quick action would be to rename the nbclassic entrypoints to ``` 'jupyter-nbclassic-nbextension = nbclassic.nbextensions:main', 'jupyter-nbclassic-serverextension = nbclassic.serverextensions:main', 'jupyter-nbclassic-bundlerextension =...

> A quick action would be to rename the nbclassic entrypoints ... this maybe the easiest and most relevant option. We ensure portability of code (a notebook 6 extension will...

> I agree with @bnavigator, we should just remove the entrypoint definitions from the notebook package, since we depend on nbclassic already. notebook 7 will depend on nbclassic, notebook 6...

Hi @kevin-bates I am happy to review this. From last discussions, such changes should occur in the nbclassic repository. The plan is then to create a 6.5.x branch that will...