ThomasV
ThomasV
It is a bit ugly to replicate the for loop that calls `wallet.set_label`. That code has been duplicated from `wallet.py` (legacy path) to `bip329.py`. In general, you should avoid copy-pasting...
> Note: conceptually there are two different options here: > > * only restrict history server to bookmarked set, other connected nodes can be any > > * restrict all...
Actually, I realize we do not need 4 connection modes. The current "manual selection" and "oneserver" modes could be extended to use bookmarks: - in the "manual selection" mode, we...
Note: I'm going to rebase this in a new branch. Since it is not possible to change the source branch of a PR, I guess this means that the conversation...
new branch, rebased on current master: https://github.com/spesmilo/electrum/commits/anchor_commitments_2022 changes: * the wallet password is not stored anymore. Instead, we will send funds to a new sequence of addresses, derived from `ln_xprv`....
new rebase: https://github.com/spesmilo/electrum/commits/anchor_commitments_2024
opened PR #9264
commits were reworked and merged in #9264
I think the '.' is desirable in the GUI. Even if the base unit is satoshis, LN payments may have millli-satoshi precision. (although this is not rendered now)
> Even when the decimal point is the last character displayed, are you sure? I never saw that anywhere before and therefore thought its a bug in Electrum. I find...