ThomasV

Results 175 comments of ThomasV

this is because you have trampoline enabled, and we do not have any hardcoded trampoline for testnet4. Disable trampoline in your settings if you want to manually enter a node

The code in `plugin.py` now branches in two places depending on the python version, bumping to 3.10 would allow us to simplify that. Besides, the `aionostr` package fails our tests...

note: unit tests are now failing with python 3.8, due to PyQt6-sip: ` ERROR: Failed building wheel for PyQt6-sip`

`aionostr` uses the `websockets` package. apparently, that package does not work with a proxy. https://stackoverflow.com/questions/47225488/client-websocket-connect-through-proxy maybe we could use `websocket-client` instead.

Closing this. We should distribute proper python package. New project in https://github.com/spesmilo/electrum-ecc

Thanks for the pull request. A few remarks: - I do not see why this should be a plugin. Plugins are generally associated with third party services. - Electrum already...

your PR includes commits from master. please rebase your branch on current master to avoid that. please also squash your commits; we do not need the old version with plugin...

you can run the tests locally on your machine, for example `python3 -m unittest electrum/tests/test_lnpeer.py`

you can see that the flake8 test is not passing. just click on the "details" link to see the error.

indeed, that flake8 issue comes from master. but it has been fixed two days ago. I guess your branch is based on one of the faulty commits. why don't you...