Eyal Kalderon

Results 126 comments of Eyal Kalderon

Thanks for opening this issue! It's a good idea to track this for the sake of completeness, regardless of priority.

I think it should be pretty trivial to expose a server-to-client progress notification API in the form of a new `Client` method which uses `ProgressToken`s to report progress. However, I...

In addition, perhaps we could return a more manual API like this: ```rust impl Client { pub fn progress(&self, title: T, message: M) -> Progress where T: Into, M: Into;...

Now, according to the specification, it's technically possible for a `WorkDoneProgressBegin` or `WorkDoneProgressReport` notification to start out with a `percentage` and/or `cancellable` field, but as soon as either or both...

Original suggestion from #206.

Thanks for looping me in! I don't have a particularly strong stance for or against this addition either. Personally, when I write servers I try to make the underlying state...

Actually, upon further inspection, it seems that `tower-balance` has not been released yet. What is the current status of this crate?

@carllerche What is the current status of the `tower` ecosystem? I know there is a lot of work being done migrating `tokio` and `hyper` and other libraries to `std::future::Future`, but...

After a bit more digging through the specification, I actually wonder whether a `CancellationToken` is truly the right approach. I have two reservations with the approach outlined above: 1. Passing...

Good point, @Timmmm! The struct in question referenced in the documentation refers to [`lsp_types::DidChangeWatchedFilesRegistrationOptions`](https://docs.rs/lsp-types/0.74.2/lsp_types/struct.DidChangeWatchedFilesRegistrationOptions.html), and if you look at the [official LSP specification](https://microsoft.github.io/language-server-protocol/specification) (Ctrl+F for `DidChangeWatchedFilesRegistrationOptions`) you should be able...