tower icon indicating copy to clipboard operation
tower copied to clipboard

Update project status in README

Open ebkalderon opened this issue 5 years ago • 9 comments

According to the README, only the foundational traits in tower-service have been released to crates.io, when in fact, it appears that all of the tower crates in this repo are available for download via Cargo. This should be updated to reflect the current project status.

Optionally, it would be nice to also link to tower-grpc, tower-h2, tower-http, etc. in this section as well, but that's not critical, I think.

ebkalderon avatar Apr 30 '19 05:04 ebkalderon

Actually, upon further inspection, it seems that tower-balance has not been released yet. What is the current status of this crate?

ebkalderon avatar May 03 '19 09:05 ebkalderon

It is pending a refactor. We want to figure out how to generalize the instrumentation. It could be published if needed and the refactor triggers an 0.2 release.

carllerche avatar May 03 '19 14:05 carllerche

Could we possibly get some examples of a basic TCP service using tower? It seems many of the examples are hidden in the documentation, and sometimes not totally complete. I'd like to point to the HTTP example in tower-service

Edit: It appears there is examples, and they should be hyper linked if not added into the main repository via readme. Though I do still recommend adding them into the project simply because it provides resources for offline developers & can spare development time.

Skarlett avatar May 04 '19 00:05 Skarlett

Would be nice. I'm hoping to get tokio-tower polished and part of the examples... hint hint @jonhoo.

We also probably should update Tower to std::future...

carllerche avatar Jun 27 '19 18:06 carllerche

@carllerche I think tokio-tower is in pretty decent shape -- seems to work well enough for Noria! Something in particular you're looking for there?

jonhoo avatar Jun 28 '19 00:06 jonhoo

@carllerche What is the current status of the tower ecosystem? I know there is a lot of work being done migrating tokio and hyper and other libraries to std::future::Future, but has any of the same thought been put into tower lately?

ebkalderon avatar Jul 27 '19 11:07 ebkalderon

@ebkalderon most of the focus has been around tokio and hyper, but there has been some work around updating tower to std::future::Future. Currently, there is a draft PR https://github.com/tower-rs/tower/pull/295 and https://github.com/tower-rs/tower-grpc/pull/188.

LucioFranco avatar Jul 27 '19 15:07 LucioFranco

Hi, I wanted to contribute to this but I am seeing two issues in maintaining the README:

  1. Some of the crates have been moved to archived state so should they be removed?
  2. Additionally some crates are available on crates.io but do not have a GitHub repository. They seem to have last commits in 2018/2019 so would you consider retaining them?

srikwit avatar Apr 21 '20 22:04 srikwit

@srikwit we moved all the crates into the main crate so I think we can replace that list with a list of modules and their feature flags in the readme and also possibly the main crate docs. Let me know what you think!

LucioFranco avatar Apr 21 '20 23:04 LucioFranco