Eyal Kalderon

Results 126 comments of Eyal Kalderon

Sure, @lpil! I can amend the README to include a link to `tower-test`.

I have found some interesting information regarding the Language Server Protocol's consistency requirements that could help inform our future design moving forward. First, the specification describes the correct server behavior...

Thanks for the suggestions and helpful discussion! However, there is unfortunately trouble associated with the use of `buffer_unordered()`, as described in commit https://github.com/ebkalderon/tower-lsp/commit/456856b2d114f624d6bb6488ffbcc54e3efef60d which makes it undesirable. The issue is...

That's certainly a possibility, @Timmmm. Though it would be a shame to disallow scenarios such as @samscott89 described in this server. I do feel like this use case should be...

Precisely! Indeed, I'm not entirely sure whether the added complexity will be worth it, but I think it's worth prototyping in a branch and mulling over. For now, in the...

Seems like the approach described a few comments up might be a good way to address the `&mut` methods suggestion mentioned in [this Reddit comment by u/matklad](https://www.reddit.com/r/rust/comments/tbsiv5/comment/i0exnbi/?utm_source=share&utm_medium=web2x&context=3).

Sure, that sounds like it would be a great addition! Provided that the documentation isn't too heavy to the point of distraction and focuses primarily on explaining "why" and "how"...

I think this is a great idea! Normally, the solution for this would be to use a `Mutex` or `RwLock` to manage synchronization of the `files` field. We could write...

I wholeheartedly recommend this! I especially recommend `codespan` and `codespan-lsp` for handling text spans and code diagnostics because it interoperates directly with `lsp-types`, a foundational crate used by `tower-lsp`. I...

Thanks for the kind words! While I think it's a pretty good example of `tower-lsp` on its own, but I feel it's hardly clean enough to recommend to new users...