Easwar Swaminathan

Results 540 comments of Easwar Swaminathan

@sebastianjonasson : You are correct in your assessment about when the timer is created in the DNS resolver's watcher goroutine. I was also going to fix it the same way...

After some thought, I've come to the understanding that I don't necessarily like the approach taken in the PR linked above because it still causes multiple picker updates and testing...

@atollena : Looks like there are some merge conflicts. Could you please take care of them before I start looking. Thanks.

> Thanks @easwars, I answered all your comments. This is ready for another round. Thank you very much for patiently addressing all comments and thank you again for doing this.

Thanks @atollena for handling all the comments and for your continued contributions.

Thank you very much for all the effort in porting the tests and uncovering these issues.

I probably need to add one more test where the xDS clients are talking to different management servers, and receiving different resources. But the review can start prior to that,...

`TestDumpResources` is failing because the test context is expiring before we test can read the expected config dump from the xDS clients. My guess at this point is that because...

Tests are passing now. This is good to be looked at.

Looks like there is a flake in the csds e2e test. I will continue to look at that, but this is still good for a second pass. Thanks.