Easwar Swaminathan comments

Results 540 comments of


                                            Easwar Swaminathan

credentials/google/google not working with oauth2 and ADC

@costinm : Is this still an issue for you? We haven't heard any other reports of this not working and all of our interop tests use ADC with xDS and...

credentials/google/google not working with oauth2 and ADC

@costinm : Do you happen to have a test that we can use, that can repro this issue? Thanks.

xds: Delete check for router filter being last in config selector

@Aditya-Sood

xds: Delete check for router filter being last in config selector

If you scroll all the way to the bottom of `unmarshal_lds_test.go`, you will find a bunch of custom filter implementations used by the test such as `clientOnlyHTTPFilter`, `serverOnlyHTTPFilter`, `errHTTPFilter` etc....

xds: Delete check for router filter being last in config selector

> Thank you, this is really helpful One quick query - do we need to create a `terminalNonRouterHTTPFilter` as well? (To cover the test case of a terminal filter failing...

xds: Delete check for router filter being last in config selector

Is there an issue with checking that the last filter is in fact the router filter and not just *any* terminal filter?

xds: Delete check for router filter being last in config selector

Currently the config selector is checking if the last filter is the router filter, which doesn't seem like the correct place to have that check. If we at all should...

xds: Delete check for router filter being last in config selector

@Aditya-Sood : Sounds good.

TCP Connection reset after a single lost keepalive packet

Our keepalive implementation is based on proposals [A8](https://github.com/grpc/proposal/blob/master/A8-client-side-keepalive.md) and [A9](https://github.com/grpc/proposal/blob/master/A9-server-side-conn-mgt.md). Any changes here would need to made across grpc implementations. If you want to propose any changes to this spec,...

TCP Connection reset after a single lost keepalive packet

Thanks for the explanation @Lucaber Do you see the problem even in the case where you set both `keepalive.ClientParameters.Time` and `keepalive.ClientParameters.Timeout` on the client and `keepalive.ServerParameters.Time` on the server to...