Easwar Swaminathan
Easwar Swaminathan
Consider adding comments like this to methods which are expected to be called with the lock held. This helps when you are reading the code and you suddenly land on...
The [HTTP/2 spec](https://datatracker.ietf.org/doc/html/rfc7540) contains the following: ``` An endpoint can use the SETTINGS_MAX_HEADER_LIST_SIZE to advise peers of limits that might apply on the size of header blocks. This setting is...
@ejona86 : How does Java behave in this scenario? Thanks.
On both the client and server, when receiving a headers frame which exceeds the configured `maxHeaderListSize`, we end up closing the stream with a `http2.ErrCodeFrameSize`. I couldn't figure out if...
> This doesn't sound right, as that error is intended for violations of SETTINGS_MAX_FRAME_SIZE. When creating a new client transport: - we either use either the configured value or the...
> I wasn't disagreeing with your assessment. I was stating that the behavior was incorrect AIUI. It isn't clear to me from the spec what the error code should be....
https://github.com/grpc/grpc-go/runs/5634991537?check_suite_focus=true
https://github.com/grpc/grpc-go/runs/7662833877?check_suite_focus=true
We would be happy to review if you can send a PR for this. Thanks.
Yes, I agree this is a good to have feature. But we don't have the dev cycles to get to this any time soon. So, if you would like to...