Eugene Voloshchak
Eugene Voloshchak
> While what the backend should return if frontend post the same data without change? I agree returning empty data looks weird. I think the backend can consider to return...
> In this case the backend will auto fix the html of user markdown input What if we don't update the message if backend has returned an error? 1. Send...
@deetergp, as per @eh2077's [proposal](https://github.com/Expensify/App/issues/17785#issuecomment-1526892819) > But after the backend corrects the overlapping html and compares with original html, it figures out that frontend sends the same html to save....
> I think for now we should go with @eh2077's proposal and just skip rendering invalid markdown will suffice. I'd wager that we'll end up ripping out the backend code...
Not overdue, this is on hold for https://github.com/Expensify/App/issues/4114
Not overdue, still on hold
Still on HOLD, the latest update in https://github.com/Expensify/App/issues/4114#issuecomment-1615999691 is > Still waiting for Meta's team decision about how to merge the Hermes PR.
> Sent an offer to @eVoloshchak via Upwork for the PR review. @sakluger, no need for Upwork, I get paid via NewDot I'll request the payment for this on 20th...
- The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28976 - The offending PR has been commented on, pointing out the bug it caused and...
**Regression Test Proposal** Preconditions: 1. Admin and employee are part of a Collect workspace 2. Admin is also approver in the Collect workspace Test steps: 1. [Employee] Create a manual...