Eugene Voloshchak

Results 102 comments of Eugene Voloshchak

Thank you! I've actually encountered the same issue for iOS, is there a possibility this could have been fixed in 2.6.1 too?

Was it added? Are you planning to add it in the future?

@tienifr proposal looks good, confirmed it working on all of the platforms A couple of small things: - Is there a way to obtain `clientHeight` and `paddingTop` differently? Maybe there...

> 1. The `scrollToIndex` is used in a lot of places, so I think it is better way to access clientHeight and paddingTop > 2. Because we're using sizeArray to...

> I'm updating the logic for scrollToIndex not scrollToBottom I was talking about [this](https://github.com/Expensify/App/blob/7b21103bb56eb0cf3fc1561715613d2a16c3255f/src/libs/ReportScrollManager/index.js#L14) function, but yes, I can see that your implementation calls `scrollToBottom` inside of it > We're...

> when build the optimistic data for default chat report (admin, announce) we don't set pendingFields for them @tienifr, thanks for the proposal, makes sense > I'll add pendingFields with...

@tienifr thank you for checking this > we're using buildOptimisticChatReport in 4 places: announceChatData, adminsChatData, expenseChatData, policyReport. Correct me if I'm wrong, but I can see it being used in...

> @eVoloshchak what do you think of the proposal? I wasn't able to fully test it yet, experiencing some weird problems (`createOption` is called multiple times, which breaks the proposed...

@Ollyws, your proposal doesn't work for me, but you've correctly identified the root cause of the problem 1. Correct me if I'm wrong, but [createOption](https://github.com/Expensify/App/blob/1ff9206ec817a44a368125fec9910bfd75ce0157/src/libs/OptionsListUtils.js#L239) function is not the one...