App icon indicating copy to clipboard operation
App copied to clipboard

[HOLD App #4114] [$1000] Web - Chat - Emoji are not on the same level as text messages

Open kbecciv opened this issue 1 year ago • 37 comments

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log with any account
  3. Go to any chat
  4. Send a text message
  5. Send emoji

Expected Result:

All messages are on the same level.

Actual Result:

Emoji are not on the same level as text messages.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • [ ] Android / native
  • [ ] Android / Chrome
  • [ ] iOS / native
  • [ ] iOS / Safari
  • [x] Windows / Chrome
  • [ ] MacOS / Desktop

Version Number: 1.2.84.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshot 2023-03-14 193851

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01438ba8598c2d6f9f
  • Upwork Job ID: 1640325165549940736
  • Last Price Increase: 2023-03-27

kbecciv avatar Mar 14 '23 21:03 kbecciv

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

MelvinBot avatar Mar 14 '23 21:03 MelvinBot

Bug0 Triage Checklist (Main S/O)

  • [ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • [ ] This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • [ ] This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

MelvinBot avatar Mar 14 '23 21:03 MelvinBot

I am unable to reproduce on web or desktop

Web example 2023-03-15_10-46-41

Desktop example image

I am going to close until there are more instances of this issue being reproducible.

davidcardoza avatar Mar 15 '23 14:03 davidcardoza

@davidcardoza I ask 3 testers to reproduced the issue, two with Windows 10 can reproduced, but one with MAC is NOT.

Windows 10 / Chrome

repros 23 03 red

Mac/Safari

Screenshot 2023-03-23 at 21 20 58

kbecciv avatar Mar 23 '23 21:03 kbecciv

Going to send this off for external.

davidcardoza avatar Mar 27 '23 12:03 davidcardoza

Job added to Upwork: https://www.upwork.com/jobs/~01438ba8598c2d6f9f

MelvinBot avatar Mar 27 '23 12:03 MelvinBot

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

MelvinBot avatar Mar 27 '23 12:03 MelvinBot

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

MelvinBot avatar Mar 27 '23 12:03 MelvinBot

Triggered auto assignment to @hayata-suenaga (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

MelvinBot avatar Mar 27 '23 12:03 MelvinBot

Not sure why melvin added me!

laurenreidexpensify avatar Mar 28 '23 13:03 laurenreidexpensify

@davidcardoza @eVoloshchak @hayata-suenaga this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

MelvinBot avatar Mar 28 '23 18:03 MelvinBot

Hi @davidcardoza @eVoloshchak @hayata-suenaga , I had raised a similar issue on slack 2 months back, link to slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1672822588617709 Can you have a look once to it? If it is same, will I be eligible for reporting bonus?

dhanashree-sawant avatar Mar 29 '23 08:03 dhanashree-sawant

@dhanashree-sawant Yes. However, this job has not been picked up by a contributor. There are no reporting bonuses being processed until the issue is completed.

davidcardoza avatar Mar 29 '23 15:03 davidcardoza

@davidcardoza sure that's okay, thanks for going through my report and considering it for this issue.

dhanashree-sawant avatar Mar 29 '23 16:03 dhanashree-sawant

Not overdue, waiting for proposals.

davidcardoza avatar Apr 03 '23 17:04 davidcardoza

@davidcardoza @eVoloshchak @hayata-suenaga this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

MelvinBot avatar Apr 04 '23 09:04 MelvinBot

posted on slack

hayata-suenaga avatar Apr 04 '23 15:04 hayata-suenaga

We are refactoring emojis here so I think we should HOLD this issue until the other one is done.

pecanoro avatar Apr 04 '23 15:04 pecanoro

@pecanoro thank you for letting us know. Put hold on this PR. Will delete the slack post I posted above.

hayata-suenaga avatar Apr 04 '23 15:04 hayata-suenaga

Not overdue, this is on hold for https://github.com/Expensify/App/issues/4114

eVoloshchak avatar Apr 17 '23 14:04 eVoloshchak

Still on hold

davidcardoza avatar Apr 26 '23 18:04 davidcardoza

Still on hold.

davidcardoza avatar May 04 '23 21:05 davidcardoza

the issue for which this PR is on hold is still being worked on

hayata-suenaga avatar May 15 '23 20:05 hayata-suenaga

still on hold

hayata-suenaga avatar May 24 '23 22:05 hayata-suenaga

still on hold

hayata-suenaga avatar Jun 12 '23 01:06 hayata-suenaga

Not overdue, still on hold

eVoloshchak avatar Jun 22 '23 16:06 eVoloshchak

Emoji refactoirng is still going on. still on hold

hayata-suenaga avatar Jun 22 '23 19:06 hayata-suenaga

latest update on the emoji refactoring here. still HOLD

hayata-suenaga avatar Jul 03 '23 16:07 hayata-suenaga

Still on HOLD, the latest update in https://github.com/Expensify/App/issues/4114#issuecomment-1615999691 is

Still waiting for Meta's team decision about how to merge the Hermes PR.

eVoloshchak avatar Jul 13 '23 15:07 eVoloshchak

still waiting for Meta

hayata-suenaga avatar Jul 24 '23 16:07 hayata-suenaga