David Zearing

Results 62 comments of David Zearing

Thanks for your hard work @evanw. Correctness is best to prioritize. We are referencing this bug to let teams know this area is stabilizing.

@zanettin sorry for the slow response! I missed the notifications. I hadn't gotten anywhere on this, and just tried latest qwik with the same repro. (cc @noeliadv - nope, hopefully...

OK so I did manage to get some styles rendering in the host app, but it needs some automation I think. Maybe a better solution. I'm not 100% familiar with...

I don't think so. At least, the boilerplate "component library" template components which `npm create qwik@latest` produces look like this: ![image](https://github.com/BuilderIO/qwik/assets/1110944/a8dd99c5-8a7d-416e-8cd4-d0dc177136aa) But... none of the files in the example are...

I think the optimizer, or at least css extraction, really should not be operating on a component library. The component library is going to produce an intermediate npm package that...

@wmertens I did try to rename my `button.tsx` to `button.qwik.tsx` but no change. The component-library demo app gets styles. The app importing the button does not get button styles without...

Or we have some separate standalone library support validating api surface diffing. I think @kenotron was working on this.

@CraigMacomber You can get pretty far with just eslint rules. Some ideas: Disallow from importing from barrel files and `.`. Only import from source directly and avoid barrel files. This...

@cungminh2710 Is there any progress on this?

Yeah inject didn't work due to the temp files. I tried modifying the plugin, but ended up not going this route. Instead I just use systemjs builder APIs directly and...