David Zearing
David Zearing
I've been thinking about it. I think the most ideal would be to do something possibly expensive at runtime, but removable at build time, like: ```js if (name === 'padding')...
Fabric core only exposes the typography and some colors/animations/css grid helpers. So i don't think you'll get very far there. Each component defines css rules in js for the most...
I have further pinpointed the issue: `Pivot.base.js` imports `PivotItem` from `./index.js`, which exports `Pivot.base.js`. There's a circular dependency here which I think is confusing the esbuild ordering.
@evanw Thanks, no worries. I've pushed a fix to Fluent UI to remove the cycle from inside of `Pivot.base.js`, so that's a workaround on our end. We'll keep going.
@ChibiBlasphem I wasn't sure on the best wording. My point was less about the specific case, and more about listing out what "still works like you'd expect", but also "where...
Yes! That fixed it. I changed to `module: "nodenext"` and added `type: "module"` to the package.json to achieve the expected output (ESM by default, CJS for cjs files.)
I am unblocked here. I do still think it's not ideal to be emitting invalid cjs but at least I have a workaround. :)
I would also +1 to Jason's remarks above - adding features to d.ts files in minor releases forces producers to never minor bump typescript. This is incredibly unfortunate because we...
I think extra release notes are great but it's ignoring the fact that if a producer upgrades ts and considers using said new feature, they now have mental math to...
> In the .d.ts file we should then do what? Good question! What would `downlevel-dts` do? I think that's the answer. I'm guessing that it would translate to `any` or...