graphql-code-generator icon indicating copy to clipboard operation
graphql-code-generator copied to clipboard

export type to support isolatedModules

Open cungminh2710 opened this issue 3 years ago • 4 comments

Description

Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'

Related # (issue)

Close #6773

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

cungminh2710 avatar Nov 08 '22 03:11 cungminh2710

🦋 Changeset detected

Latest commit: 53a60efc032b16f395fc56f9234f2d38c293ce98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 08 '22 03:11 changeset-bot[bot]

@cungminh2710 Is there any progress on this?

dzearing avatar Oct 31 '23 14:10 dzearing

@dzearing hi there, i forgot to work on this. Will address some feedback soon this week

cungminh2710 avatar Oct 31 '23 22:10 cungminh2710

@saihaj it's been a while. any chance to land this PR?

cungminh2710 avatar Aug 19 '24 12:08 cungminh2710