Dylan Hardison

Results 17 comments of Dylan Hardison

aren't the changes in 5.2 sufficient for this? Though at this time I'd be happy to drop all support for utf8 (in favor of the correct utf8mb4

This looks good to me; asking @gerv to test it if possible.

> process_bug.cgi does not check that user is in group bulk_edit that I can tell and allows anyone to bulk edit. But the template does check. Which policy do we...

> @dylanwh i am curious why need to “ run Makefile.PL” ? Usually all compilation happens insider docker build, right ? Side effect of two constraints: 1. Extensions can change...

> What is a necessity of “BZ_urlbase”, if this is a bugzilla api URL , usually there is docker port mapping mechanism that would allow map docker tcp ports to...

@justdave can you rebase this against the unstable branch, and then force push it?

Current problem: chicken/egg with the new columns in the profiles table ``` DBD::mysql::db selectrow_hashref failed: Unknown column 'profiles.nickname' in 'field list' [for Statement "SELECT profiles.userid,profiles.login_name,profiles.realname,profiles.mybugslink AS showmybugslink,profiles.disabledtext,profiles.disable_mail,profiles.extern_id,profiles.is_enabled,DATE_FORMAT(last_seen_date, '%Y-%m-%d') AS last_seen_date,profiles.password_change_required,profiles.password_change_reason,profiles.mfa,profiles.mfa_required_date,profiles.nickname,profiles.bounce_count,first_patch_reviewed_id,review_request_count,feedback_request_count,needinfo_request_count,comment_count,creation_ts,first_patch_bug_id,last_activity_ts,last_statistics_ts...

Fixed the previous errors. now we have ``` DBD::mysql::db do failed: Cannot change column 'attach_id': used in a foreign key constraint 'fk_bugs_activity_attach_id_attachments_attach_id' [for Statement "ALTER TABLE bugs_activity CHANGE COLUMN attach_id...

ok, worked past those. now we're at this error ``` Can't call method "id" on an undefined value at /Users/dylan/Git/bugzilla/harmony/extensions/BMO/Extension.pm line 1542. ```