harmony
harmony copied to clipboard
bugzilla
Bug 103866: show bugs blocked by unresolved dependencies
https://bugzilla.mozilla.org/show_bug.cgi?id=103866
Not tested, but the code looks clean and looks like it should do what it says on the tin. Roping in Kyohei to look because it's search UI (well, buglist UI really - it's just an additional column you can pick to display).
I see "issues":
- Is there anything that can be done to tidy up this storm of commits and merge-commits?
- The merge conflicts need fixing
- The tests need to be passing
- Can the
.gitignorechange for.DS_Storeget put ontomasterand all other main branches to eliminate this as a thing showing in PRs?
@justdave can you rebase this against the unstable branch, and then force push it?
@justdave can you rebase this against the unstable branch, and then force push it?
There's a lot of conflicts in code that I have no clue how it works and don't know what the intended change was to know what to merge.
Looks like something got merged here that wasn't meant to be, the conflicts all have nothing to do with the patch. What branch should be the target for this merge? It's been a couple years since this was posted. Is unstable still appropriate or should it go on main?
OK, I re-created my local branch from unstable, then cherry-picked this patch off the original upstream branch, then force-pushed it back.
* Is there anything that can be done to tidy up this storm of commits and merge-commits?
Pretty much what I just did.
Want this re-approved to ensure it's going on the correct target branch
I don't think we use the unstable branch any more, do we? I think the last commit there predates the most recent BMO sync.
Confirmed with Dylan on Discord that unstable is dead and this should be rebased against main.
Which is going to require repeating the steps from https://github.com/bugzilla/harmony/pull/8#issuecomment-898862296 again...