Marcin Pączkowski

Results 611 comments of Marcin Pączkowski

> But, this could definitely be a "me not understanding GitHub" situation...is this because the changes have been "approved" but not actually "merged" yet? Yes, that's exactly the case. The...

Hello @elifieldsteel, now that https://github.com/supercollider/supercollider/pull/5836 is in, we'll need to remove the commits that were already merged from this PR. Instructions to follow.

One can edit commits on a particular branch by doing an [interactive rebase](https://github.com/supercollider/supercollider/wiki/Creating-pull-requests#rebasing-to-rearrange-and-edit-commits). Our wiki is fairly limited on the topic, likely because it's a somewhat of a delicate process...

These look like the changes to git submodules. They show up when switching between branches that refer to different versions of submodules (e.g. some old branch before there were updates...

> > I believe this would be fixed by updating the submodules: > > `git submodule update --init --recursive` > > This cleared up the three changes not staged for...

Thanks @elifieldsteel , this PR looks good now and I'm glad my instructions were helpful. I know they were specific to this case (branch names etc), but I personally often...

IIUC we are in the process of changing (fixing?) tests on CI so they use the built-in testsuite, instead of the CommonTests quark: #3132. After that's merged, this PR would...

@mtmccrea I also like how it looks. If the `system` palette follows OS settings (I assume it would?), I'd just make sure that it looks fine when using the light...