David Renshaw

Results 176 comments of David Renshaw

What's the reasoning behind changing the tactic from `rename_var` to `rename_bvar`?

What would the reason be for that modification to `Cargo.toml`? Does `cargo build --example create_tweet` not work?

Does this actually let you use the value where you want to? In https://github.com/capnproto/capnproto-rust/pull/225 I found that Rust was more restrictive than I expected about where associated constants can be...

I like this change, but it will require a version bump. I'm thinking I'll do the version bump next week, pulling in this, #225, and #275.

Ah, I was assuming that you were removing the `type_id()` method, but I see now that you're keeping it and adding a default impl. Yeah, that's less risky, and we...

Hm... I agree that this probably won't cause a problem for anyone who generates code just-in-time in a `build.rs`. However, some users generate code once beforehand and check in the...

Looks like Generic Associated Types are likely to be arriving soon: https://github.com/rust-lang/rust/pull/96709 I'm inclined to say that we should delay our major version bump until then, so that we can...

Merging now, to be included in the 0.15.0 release, which I intend to make after Rust 1.65 comes out next week.

I think think would be fixed by https://github.com/hansjorg/rust-ci/pull/16. Meanwhile, a workaround is to add this to your .travis.yml: ``` after_script: - cp -r target/doc doc ```