David Renshaw

Results 176 comments of David Renshaw

I like the idea of more documentation. I haven't had time to fully understand what you're doing here with the helper crate. All else being equal, I would prefer to...

This would be really cool -- much better than my current hack for getting Cargo to do code generation, which you can see in these two repositories: https://github.com/dwrensha/capnp-rpc-rust https://github.com/dwrensha/acronymy

This seems like it would be a reasonable feature. To support it, we would add an annotation to [rust.capnp](https://github.com/capnproto/capnproto-rust/blob/267b8b8939fb63b1765741617b98d1029466c917/capnpc/rust.capnp) I wonder whether there might be any common ground between this...

There is no equivalent of `CapabilityServerSet` yet in Rust. I don't know how difficult it would be to add.

[`CapabilityServerSet`](https://github.com/capnproto/capnproto/blob/1db1e9f01a8d9dc065b58b8c47b16fbded86859c/c%2B%2B/src/capnp/capability.h#L527-L553) requires downcasting, which Rust does not support in the way that C++ does. In the case of `web-publishing.capnp`, I think we can get away with something simpler. Instead of...

> Why can't be associated data be a reference to the server object itself? You can get a reference to the `dyn capability::Server`, but you can't convert that into a...

OK, I think I see a way to make `CapabilityServerSet` work. I put up some first steps in #174. The new `IntoClient` trait should make it possible for a `CapabilityServerSet`...

A crucial finesse here is that the `Rc` should wrap the thing (i.e. `ServerDispatch`) implementing the base `capnp::capability::Server` trait, rather than the thing implementing the particular `foo::Server` trait from the...

I've landed #174. The new trait is now `FromServer`, not `IntoClient` (type inference works out better that way): https://github.com/capnproto/capnproto-rust/blob/4271dca53868927cc580cc06df92aa6d6ac637c6/capnp/src/capability.rs#L254-L260