Devin Nusbaum

Results 106 comments of Devin Nusbaum

I have no plans to review this. My impression from a very brief look at the code was that it seemed quite complicated, but I am not blocking it. IMO...

https://github.com/jenkinsci/workflow-api-plugin/pull/388 now has a test that requires `GCFlushedOutputStream`, so we can at least verify that it works as intended under specialized conditions. I'm closing this in favor of that PR...

Hmm, some of the changes in 755fec8fdd37a72d7e4dc1e9a7ca30b801093c62 might make the migration admin monitor trigger even for brand new app credentials. If so, we might need to swap back to setting...

Thanks @darinpope. The former I think just needs a release of https://github.com/jenkinsci/kubernetes-credentials-provider-plugin/pull/107. The latter failures I think are all related to the incompatibility mentioned in the release notes [here](https://github.com/jenkinsci/github-branch-source-plugin/releases/tag/1844.v4a_9883d49126). The...

Yes, I think https://github.com/x-stream/xstream/pull/106 would have prevented the main issue here. > Are there other cases where XStream throws RuntimeException where we'd like for one of our Robust*Converter classes to...

> There are some converters in plugins though which call moveDown without checking for children. So far, most of the calls in significant plugins seem to be ok, or the...

Here is an example of the error message with [41433d8](https://github.com/jenkinsci/jenkins/pull/9653/commits/41433d8c886ab58deaf82058229e55d83774fe4b) showing that the path to the relevant element is included in the message: ``` Aug 26, 2024 3:53:16 PM hudson.diagnosis.OldDataMonitor...

Not sure what the preferred process is here. The PR has the necessary approvals. Should I just add the `ready-for-merge` label?

I finally had a bit of time to test this. As far as I can see, `pipeline-cloudwatch-logs` does not care either way, because it does not use `BufferedBuildListener`, `GCFlushedOutputStream`, or...

The CodeQL autobuild doesn't like the HPI plugin override (interestingly I also get this error in Netbeans, but it works fine using Maven directly): > [2024-09-27 19:27:07] [autobuild] org.apache.maven.project.ProjectBuildingException: Some...