Devin Nusbaum

Results 105 comments of Devin Nusbaum

This was fixed incidentally as part of https://github.com/jenkinsci/groovy-sandbox/commit/520243213bcd8c81322e8e683daa8d555bb4f484 and was released in version 1.30.

I think the problem is the definition of `getLoginName`: ``` public String getLoginName() { return loginName; // Replace with `return this.@loginName` as a workaround. } ``` A workaround is to...

Thanks for the bug report! I looked into this today to try to understand whether the bug could be used to bypass the sandbox by confusing the transformer. I think...

@martinda The problems here are kind of obscure because `SimpleTemplateEngine` interacts directly with APIs like `GroovyShell.parse` and `Script.run`, and I am not super familiar with `SimpleTemplateEngine` in the first place,...

@martinda In this case, you cannot use `SecureGroovyScript`, because you are not just directly running a user-provided Groovy script, you are running it as part of `SimpleTemplateEngine`. You need to...

> Is there a reason this is still in draft? Yes, because it should not be released until the downstream PRs are in widespread use on the relevant baseline or...

Currently, for users running Jenkins 2.332.1 or newer: * `pipeline-model-definition`: 31364 installations are running the required plugin version out of 121820 (45% of 270710) that are running a new enough...

As of the August update to https://stats.jenkins.io/, for users running Jenkins 2.332.1 or newer: * `pipeline-model-definition`: 93004 installations are running the required plugin version out of 141134 (52% of 271413)...

@totoroliu I think [SelfPromotionTest#testBasic](https://github.com/jenkinsci/promoted-builds-plugin/blob/e4c9304553f2868f67556644f5831eba60cf2c34/src/test/java/hudson/plugins/promoted_builds/conditions/SelfPromotionTest.java#L32) uses 2 self promotion conditions, so maybe you could use that but change one of them into a ManualCondition that you never trigger to show your...

Rebuilding. Also, I checked the behavior for cases where users have an invalid approved signature in their `scriptApproval.xml`. Previously, the behavior was wrong, but it was wrong both when checking...