Devin Nusbaum

> BTW Re-run from Checks should work. Hmm, it never seems to work for me. I will try that next time though.

@totoroliu I'll try to take a look at the new changes sometime this week, thanks!

Also just a note: For any job with a parameterized approver for its manual promotion condition, all Job/Build users would be able to allow anyone to promote the job. Previously,...

Please don't force-push, it makes it difficult to review the PR since we cannot tell what changed each time and have to review everything from scratch. It's ok to have...

I think that you would replace a line like the following: FreeStyleBuild b = j.assertBuildStatusSuccess(p.scheduleBuild2(0)); with the following (although I have not tested it): FreeStyleBuild b = j.assertBuildStatusSuccess(p.scheduleBuild2(0, new ParametersAction(new...

I do not necessarily think there is anything wrong with a step like this, although I would make it set the build status as well by default. I agree with...

> So it sounds like it would work out to add a simple flag to both unstable and warnError to suppress¹ the current behavior of setting Run.result, but continue to...

> I have a mild preference for a flag on the existing steps over introducing a new step or steps, but do not feel strongly about it Same for me....

To clarify, for the new step I described, there would be no way to set distinct build and stage results (too niche in my opinion), and there would be a...

@krotte1 we don't currently have a great process for evaluating new features like this, but we are working on improving it. For now, can you [create a Jira ticket](https://issues.jenkins-ci.org), component...