David Luzar

Results 833 comments of David Luzar

> `App.tsx` along with the modules used in it is contributing ~500kb Yeah, and that is a lot. I wonder what those concatenated modules are. Either way, we def need...

In the interest of simplifying the Sidebar implementation and behavior, I will remove all the implicit behavior and rendering, and force host apps to render Header/Header buttons (close/dock) themselves, as...

> However as per the default dock state - by default the sidebar will not be docked right ? So right now the DefaultSidebar still uses `appState.isSidebarDocked` both for fallback,...

There's one issue which I don't know how to solve: when the default sidebar's `docked` state is controlled from host app. One question is if the sidebar should be semi-controlled...

So I went with (2) https://github.com/excalidraw/excalidraw/pull/6213/commits/ff5d05c91fedb1aab30ae7825da4f4d5be2961c9, renaming `appState.isSidebarDocked` to `appState.defaultSidebarDockedPreference`. If default sidebar's `docked` prop is passed (true or false), we disable dockability, and ignore `defaultSidebarDockedPreference`. If host apps don't...

Thanks for the review @ad1992! 🎉

@excalibot trigger release

Hello @hugo082, thanks for the PR! ❤️ Works pretty well. 💪 ### Notes on behavior - Snapping threshold seems a bit large. Could turn out more problematic once we add...

Thanks @hugo082, and awesome commit notes! ❤️ Two quick things I noticed: - Snap lines should hide once you stop moving/reisizing — currently it hides only once you box-select outside....

🍉. Just a few more things we still need to fix in this PR before shipping! And I'm also writing down the things we'll leave for later. ### This PR...